Skip to content

Adding labels to the google_gke_hub_membership resource #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
spaz87 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding labels to the google_gke_hub_membership resource #2534

spaz87 wants to merge 1 commit into from

Conversation

@spaz87
Copy link

@spaz87 spaz87 commented Jan 30, 2026

This resource supports the use of labels but does not respect the provider default labels. To ensure users of the module can label their resources I have exposed that argument and created a corresponding variable.

@google-cla
Copy link

google-cla bot commented Jan 30, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @spaz87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the fleet-membership module by introducing support for resource labels on the google_gke_hub_membership resource. This change provides users with the flexibility to apply custom labels, which was previously unavailable, thereby improving resource organization and management within their Google Cloud environment.

Highlights

  • GKE Hub Membership Labeling: The google_gke_hub_membership resource now supports custom labels, allowing users to organize and manage their fleet memberships more effectively.
  • New resource_labels Variable: A new input variable, resource_labels, has been introduced to allow users to pass a map of key/value pairs as labels to the GKE Hub membership resource.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for labels on the google_gke_hub_membership resource by introducing a resource_labels variable. The implementation is straightforward and correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody Awaiting requested review from apeabody apeabody is a code owner

@ayushmjain ayushmjain Awaiting requested review from ayushmjain ayushmjain is a code owner

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@krprabhat-eng krprabhat-eng Awaiting requested review from krprabhat-eng krprabhat-eng is a code owner

@q2w q2w Awaiting requested review from q2w q2w is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@spaz87